Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php80] Keep single quoted Argument Attribute on AnnotationToAttributeRector #5214

Merged
merged 2 commits into from
Oct 29, 2023
Merged

[Php80] Keep single quoted Argument Attribute on AnnotationToAttributeRector #5214

merged 2 commits into from
Oct 29, 2023

Conversation

samsonasik
Copy link
Member

Single quoted annotation currently convered to:

-#[GenericSingleImplicitAnnotation('/')]
+#[GenericSingleImplicitAnnotation("'/'")]

which should be kept.

@samsonasik
Copy link
Member Author

Fixed 🎉 I currently applied on direct value Attribute Argument.

-@GenericSingleImplicitAnnotation('/')
+#[GenericSingleImplicitAnnotation('/')]

For key -> value usage, that will require different test case :)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 486986e into main Oct 29, 2023
41 checks passed
@samsonasik samsonasik deleted the keep-single-quoted branch October 29, 2023 13:35
@samsonasik samsonasik mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik